dongjoon-hyun commented on code in PR #43643:
URL: https://github.com/apache/spark/pull/43643#discussion_r1381206010
##########
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala:
##########
@@ -98,6 +98,11 @@ private[ui] class ApplicationPage(parent: MasterWebUI)
extends WebUIPage("app")
<a href={UIUtils.makeHref(parent.master.reverseProxy,
app.id, app.desc.appUiUrl)}>Application Detail UI</a>
</strong></li>
+ } else if (parent.master.historyServerUrl.nonEmpty) {
+ <li><strong>
+ <a
href={s"${parent.master.historyServerUrl.get}/history/${app.id}"}>
Review Comment:
It seems that I found what was the conflicts here. For the following,
actually, we have a team-wide small Spark cluster, not a giant one you are
supposed here.
> Setting spark.eventLog.dir/spark.ui.historyServerUrl in pairs is
practical, for example,
> A user wants to keep its runtime data private
##########
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala:
##########
@@ -98,6 +98,11 @@ private[ui] class ApplicationPage(parent: MasterWebUI)
extends WebUIPage("app")
<a href={UIUtils.makeHref(parent.master.reverseProxy,
app.id, app.desc.appUiUrl)}>Application Detail UI</a>
</strong></li>
+ } else if (parent.master.historyServerUrl.nonEmpty) {
+ <li><strong>
+ <a
href={s"${parent.master.historyServerUrl.get}/history/${app.id}"}>
Review Comment:
It seems that I found what was the conflicts here. For the following,
actually, we have a team-wide small Spark cluster, not a giant one you are
supposed here, @yaooqinn .
> Setting spark.eventLog.dir/spark.ui.historyServerUrl in pairs is
practical, for example,
> A user wants to keep its runtime data private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
