dongjoon-hyun commented on code in PR #43880:
URL: https://github.com/apache/spark/pull/43880#discussion_r1398100978
##########
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala:
##########
@@ -262,6 +262,14 @@ class MathFunctionsSuite extends QueryTest with
SharedSparkSession {
}
}
+ test("SPARK-44973 conv must allocate enough space for all digits plus
negative sign") {
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> false.toString) {
+ val df = Seq(("8" + "0"*15), ("-8" + "0" * 15)).toDF("num")
Review Comment:
It's interesting. I expect a linter error at `"0"*15` due to the lack of
space, but it's passed.
In anyway, shall we change like this?
```
- "0"*15
+ "0" * 15
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
