markj-db commented on code in PR #43880:
URL: https://github.com/apache/spark/pull/43880#discussion_r1399540088
##########
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala:
##########
@@ -244,7 +244,7 @@ class MathFunctionsSuite extends QueryTest with
SharedSparkSession {
}
}
- test("SPARK-36229 inconsistently behaviour where returned value is above the
64 char threshold") {
+ test("SPARK-36229: inconsistent behaviour where returned value is above the
64 char threshold") {
Review Comment:
Done
##########
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala:
##########
@@ -227,15 +227,15 @@ class MathFunctionsSuite extends QueryTest with
SharedSparkSession {
checkAnswer(df.selectExpr("""conv("-10", 16, -10)"""), Row("-16"))
}
- test("SPARK-33428 conv function should trim input string") {
+ test("SPARK-33428: conv function should trim input string") {
Review Comment:
Done
##########
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala:
##########
@@ -227,15 +227,15 @@ class MathFunctionsSuite extends QueryTest with
SharedSparkSession {
checkAnswer(df.selectExpr("""conv("-10", 16, -10)"""), Row("-16"))
}
- test("SPARK-33428 conv function should trim input string") {
+ test("SPARK-33428: conv function should trim input string") {
val df = Seq(("abc"), (" abc"), ("abc "), (" abc ")).toDF("num")
checkAnswer(df.select(conv($"num", 16, 10)),
Seq(Row("2748"), Row("2748"), Row("2748"), Row("2748")))
checkAnswer(df.select(conv($"num", 16, -10)),
Seq(Row("2748"), Row("2748"), Row("2748"), Row("2748")))
}
- test("SPARK-33428 conv function shouldn't raise error if input string is too
big") {
+ test("SPARK-33428: conv function shouldn't raise error if input string is
too big") {
Review Comment:
Done
##########
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala:
##########
@@ -253,7 +253,7 @@ class MathFunctionsSuite extends QueryTest with
SharedSparkSession {
}
}
- test("SPARK-36229 conv should return result equal to -1 in base of toBase") {
+ test("SPARK-36229: conv should return result equal to -1 in base of toBase")
{
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
