dongjoon-hyun commented on code in PR #43880:
URL: https://github.com/apache/spark/pull/43880#discussion_r1398275341
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala:
##########
@@ -23,6 +23,13 @@ import org.apache.spark.unsafe.types.UTF8String
object NumberConverter {
+ /**
+ * The output string has a max length of one char per bit in the
intermediate representation plus
+ * one char for the '-' sign. This corresponds to the representation of
`Long.MinValue` with
+ * `toBase` equal to -2.
+ */
+ private final val MAX_OUTPUT_LENGTH = 64 + 1
Review Comment:
+1 for @gerashegalov 's suggestion `java.lang.Long.SIZE + 1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
