hannahkamundson opened a new pull request, #43890: URL: https://github.com/apache/spark/pull/43890
### What changes were proposed in this pull request? 1. The silencing of the widening conversion compilation warnings in the parent `pom.xml` was removed. 2. All widening conversion compilation warnings were removed. This almost exclusively involved adding `.toDouble` to longs. However, it also involved some `.toFloat` on ints and longs. ### Why are the changes needed? It allows us to upgrade to Scala 2.13 without adding a bunch of compilation issues. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No tests were added. For every profile (including the base profile), I ran `mvn clean compile test-compile`. I then `grep`ed any lines that had the word `Wide` in it. I determined I was done when no output remained. Here is a script of what was run: ```shell mvn clean compile test-compile |& tee output.txt cat output.txt | grep .*Wide.* |& tee output-widening.txt mvn clean compile test-compile -Pspark-ganglia-lgpl |& tee output-spark-ganglia-lgpl.txt cat output-spark-ganglia-lgpl.txt | grep .*Wide.* |& tee output-spark-ganglia-lgpl-widening.txt mvn clean compile test-compile -Pkinesis-asl |& tee output-kinesis-asl.txt cat output-kinesis-asl.txt | grep .*Wide.* |& tee output-kinesis-asl-widening.txt mvn clean compile test-compile -Pdocker-integration-tests |& tee output-docker-integration-tests.txt cat output-docker-integration-tests.txt | grep .*Wide.* |& tee output-docker-integration-tests-widening.txt mvn clean compile test-compile -Pyarn \& tee output-yarn.txt cat output-yarn.txt | grep .*Wide.* |& tee output-yarn-widening.txt mvn clean compile test-compile -Pkubernetes |& tee output-kubernetes.txt cat output-kubernetes.txt | grep .*Wide.* |& tee output-kubernetes-widening.txt mvn clean compile test-compile -Pkubernetes-integration-tests |& tee output-kubernetes-integration-tests.txt cat output-integration-tests.txt | grep .*Wide.* |& tee output-integration-tests-widening.txt mvn clean compile test-compile -Phive-thriftserver |& tee output-hive-thriftserver.txt cat output-thriftserver.txt | grep .*Wide.* |& tee output-thriftserver-widening.txt mvn clean compile test-compile -Phadoop-cloud |& tee output-hadoop-cloud.txt cat output-hadoop-cloud.txt | grep .*Wide.* |& tee output-hadoop-cloud-widening.txt ``` ### Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
