tgravescs commented on code in PR #43890:
URL: https://github.com/apache/spark/pull/43890#discussion_r1399438677
##########
core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala:
##########
@@ -476,7 +476,7 @@ private[spark] object ResourceUtils extends Logging {
if (maxTaskPerExec < (execAmount * numParts / taskAmount)) {
val origTaskAmount = treq.amount
val taskReqStr = s"${origTaskAmount}/${numParts}"
- val resourceNumSlots = Math.floor(execAmount * numParts /
taskAmount).toInt
+ val resourceNumSlots = Math.floor(execAmount * numParts /
taskAmount.toDouble).toInt
Review Comment:
it doesn't looks like the floor is needed here. its longs and ints, the
other functions called before this take care of doubles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
