hannahkamundson commented on code in PR #43890:
URL: https://github.com/apache/spark/pull/43890#discussion_r1399839293
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorRollPlugin.scala:
##########
@@ -150,14 +150,15 @@ class ExecutorRollDriverPlugin extends DriverPlugin with
Logging {
* Since we will choose only first item, the duplication is okay.
*/
private def outliersFromMultipleDimensions(listWithoutDriver:
Seq[v1.ExecutorSummary]) =
- outliers(listWithoutDriver.filter(_.totalTasks > 0), e => e.totalDuration
/ e.totalTasks) ++
- outliers(listWithoutDriver, e => e.totalDuration) ++
- outliers(listWithoutDriver, e => e.totalGCTime) ++
- outliers(listWithoutDriver, e => e.failedTasks) ++
- outliers(listWithoutDriver, e => getPeakMetrics(e, "JVMHeapMemory")) ++
- outliers(listWithoutDriver, e => getPeakMetrics(e, "JVMOffHeapMemory"))
++
- outliers(listWithoutDriver, e => e.totalShuffleWrite) ++
- outliers(listWithoutDriver, e => e.diskUsed)
+ outliers(listWithoutDriver.filter(_.totalTasks > 0),
+ e => e.totalDuration.toFloat / e.totalTasks) ++
Review Comment:
Nice catch! Done.
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorRollPlugin.scala:
##########
@@ -150,14 +150,15 @@ class ExecutorRollDriverPlugin extends DriverPlugin with
Logging {
* Since we will choose only first item, the duplication is okay.
*/
private def outliersFromMultipleDimensions(listWithoutDriver:
Seq[v1.ExecutorSummary]) =
- outliers(listWithoutDriver.filter(_.totalTasks > 0), e => e.totalDuration
/ e.totalTasks) ++
- outliers(listWithoutDriver, e => e.totalDuration) ++
- outliers(listWithoutDriver, e => e.totalGCTime) ++
- outliers(listWithoutDriver, e => e.failedTasks) ++
- outliers(listWithoutDriver, e => getPeakMetrics(e, "JVMHeapMemory")) ++
- outliers(listWithoutDriver, e => getPeakMetrics(e, "JVMOffHeapMemory"))
++
- outliers(listWithoutDriver, e => e.totalShuffleWrite) ++
- outliers(listWithoutDriver, e => e.diskUsed)
+ outliers(listWithoutDriver.filter(_.totalTasks > 0),
+ e => e.totalDuration.toFloat / e.totalTasks) ++
Review Comment:
Nice catch! Changed it. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
