hannahkamundson commented on PR #43890: URL: https://github.com/apache/spark/pull/43890#issuecomment-1821011476
> > Thanks for the review @LuciferYang . I fixed the changes and updated the PR. Feel free to give any more feedback :) > > If it is okay, I will break up the second line [spark/project/SparkBuild.scala](https://github.com/apache/spark/blob/398bff77b1c837aed55f4f10ff1157f7da813570/project/SparkBuild.scala#L239) into another PR because I wasn't planning on that for this one. That'll make it easier for me to keep my changes straight. > > We need to clean up the corresponding suppression rule in sbt in this pr to keep the suppression rules for Maven and sbt consistent. It doesn't need to be split into another PR. Ohh. In response to my last comments, I was thinking you were saying the line above it in Maven. I'll change the sbt one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
