hannahkamundson commented on code in PR #43890:
URL: https://github.com/apache/spark/pull/43890#discussion_r1403687119
##########
project/SparkBuild.scala:
##########
@@ -236,7 +236,6 @@ object SparkBuild extends PomBuild {
// TODO(SPARK-33805): Undo the corresponding deprecated usage
suppression rule after
// fixed.
"-Wconf:msg=^(?=.*?method|value|type|object|trait|inheritance)(?=.*?deprecated)(?=.*?since
2.13).+$:s",
- "-Wconf:msg=^(?=.*?Widening conversion from)(?=.*?is deprecated
because it loses precision).+$:s",
Review Comment:
Hm, what is the goal of replacing it? My original intent was to get all
compilation warnings that say `is deprecated because it loses
precision`/`Widening conversion from` gone. It seems like this would be adding
a compilation warning for something that isn't there. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
