LuciferYang commented on code in PR #43890:
URL: https://github.com/apache/spark/pull/43890#discussion_r1403903802
##########
core/src/main/scala/org/apache/spark/partial/CountEvaluator.scala:
##########
@@ -57,7 +57,10 @@ private[partial] object CountEvaluator {
val low = dist.inverseCumulativeProbability((1 - confidence) / 2)
val high = dist.inverseCumulativeProbability((1 + confidence) / 2)
// Add 'sum' to each because distribution is just of remaining count, not
observed
- new BoundedDouble(sum + dist.getNumericalMean, confidence, sum + low, sum
+ high)
+ new BoundedDouble(sum + dist.getNumericalMean,
+ confidence,
+ (sum + low).toDouble,
+ (sum + high).toDouble)
Review Comment:
nit:
```
new BoundedDouble(
sum + dist.getNumericalMean, confidence, (sum + low).toDouble, (sum +
high).toDouble)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
