cashmand opened a new pull request, #43984:
URL: https://github.com/apache/spark/pull/43984
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Fix two issues with the new Variant type:
1) In `InterpretedUnsafeProjection`, define element size to be 8, since
Variant has variable length, so it is categorized as a reference type, which
always has size 8. This only manifests as an issue when codegen is disabled and
an array or struct contains Variant values.
2) Define and use a `ParquetGroupConverter` for Variant. The previous tests
used the vectorized reader, so this issue didn't manifest.
### Why are the changes needed?
Fixes crashes when Variant is used.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added a unit test that writes and reads an array of Variant values with
codegen and the vectorized reader disabled. Reverting either of the two fixes
causes the test to fail.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
