cashmand commented on code in PR #43984:
URL: https://github.com/apache/spark/pull/43984#discussion_r1403927026
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedUnsafeProjection.scala:
##########
@@ -294,7 +294,7 @@ object InterpretedUnsafeProjection {
*/
@scala.annotation.tailrec
private def getElementSize(dataType: DataType): Int = dataType match {
- case NullType | StringType | BinaryType | CalendarIntervalType |
+ case NullType | StringType | BinaryType | CalendarIntervalType |
VariantType |
_: DecimalType | _: StructType | _: ArrayType | _: MapType => 8
Review Comment:
Let me know if you want me to make the `UnsafeRow.isFixedLength` change as
part of this PR (and if so, what to do about NullType).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
