cashmand commented on code in PR #43984:
URL: https://github.com/apache/spark/pull/43984#discussion_r1403906938
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -498,6 +498,9 @@ private[parquet] class ParquetRowConverter(
int96RebaseSpec,
wrappedUpdater)
+ case t: VariantType =>
Review Comment:
I think because the vectorized parquet reader is used by default, and I
guess the vectorized reader doesn't use these converters. I had to set
`PARQUET_VECTORIZED_READER_ENABLED` to false in the unit test to trigger the
failure that this part of the change fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
