andylam-db commented on code in PR #44084:
URL: https://github.com/apache/spark/pull/44084#discussion_r1411475869


##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala:
##########
@@ -349,20 +349,16 @@ class SQLQueryTestSuite extends QueryTest with 
SharedSparkSession with SQLHelper
     }
   }
 

Review Comment:
   The changes in this file looks incredibly messy, but basically I did a bunch 
of refactoring so that I can re-implement `runSqlTestCase` in 
`CrossDbmsQueryTestSuite` as well. I pulled out a bunch of code into separate 
functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to