dtenedor commented on code in PR #44084:
URL: https://github.com/apache/spark/pull/44084#discussion_r1420855965
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala:
##########
@@ -349,20 +349,16 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession with SQLHelper
}
}
Review Comment:
This is true, but it's making the PR somewhat hard to review and separate
the new behavior changes from the refactoring part. Would you mind to split off
the refactoring part into a separate PR? That will be easier to review and
prove correct since all the existing tests will behave the same and provide
coverage. Then we can sync this PR and it will be much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
