andylam-db commented on code in PR #44084:
URL: https://github.com/apache/spark/pull/44084#discussion_r1416514148
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala:
##########
@@ -98,20 +98,24 @@ trait SQLQueryTestHelper extends Logging {
}
}
+ /**
+ * Uses the Spark logical plan to determine whether the plan is semantically
sorted. This is
+ * important to make non-sorted queries test cases more deterministic.
+ */
+ protected def isSemanticallySorted(plan: LogicalPlan): Boolean = plan match {
+ case _: Join | _: Aggregate | _: Generate | _: Sample | _: Distinct =>
false
Review Comment:
This function was pulled out from below. Changing it might cause lots of
golden files changes :O
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
