Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5792#discussion_r31165623
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -62,4 +64,12 @@ private[history] abstract class
ApplicationHistoryProvider {
*/
def getConfig(): Map[String, String] = Map()
+ /**
+ * Get the [[Path]]s to the Event log files. For legacy event log
directories, directory path
+ * itself is returned. The caller is responsible for listing the files
and using them as needed.
+ * If the attemptId is [[None]], event logs corresponding to all
attempts for the given
+ * application are downloaded as a single zip file.
+ */
+ def getEventLogPaths(appId: String, attemptId: Option[String]):
Seq[Path] = Seq.empty
--- End diff --
Just a minor issue for now, but having `Path` here kinda assumes that the
logs exist in a file system, which may not be the case for different provider
implementations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
