Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5792#discussion_r31166390
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala ---
    @@ -164,6 +164,18 @@ private[v1] class ApiRootResource extends 
UIRootFromServletContext {
         }
       }
     
    +  @Path("applications/{appId}/download")
    +  def getEventLogs(
    +    @PathParam("appId") appId: String): EventLogDownloadResource = {
    +    new EventLogDownloadResource(uiRoot, appId, None)
    +  }
    +
    +  @Path("applications/{appId}/{attemptId}/download")
    --- End diff --
    
    Ah, that's too bad; wish I had caught that earlier, it's probably too late 
now. :-/
    
    Anyway, I have a slight preference for `/logs` as the URI, since REST 
generally discourages using verbs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to