Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5792#discussion_r31166176
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -219,6 +220,19 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
}
+ override def getEventLogPaths(appId: String, attemptId: Option[String]):
Seq[Path] = {
+
+ val filePaths = new ArrayBuffer[Path]()
+ applications.get(appId).foreach { appInfo =>
--- End diff --
I think this is a little more scala-y and avoids the intermediate array:
applications.get(appId).flatMap { appInfo =>
// If no attempt is specified, or there is no attemptId for attempts,
return all attempts
appInfo.attempts
.filter { attempt =>
attempt.attemptId.isEmpty || attemptId.isEmpty ||
attempt.attemptId.get == attemptId.get
}
.map { attempt => new Path(logDir, attempt.logPath) }
}
Also, probably not an issue in practice, but `attempt.attemptId.isEmpty`
should probably be removed from the filter condition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
