stefankandic commented on code in PR #44538:
URL: https://github.com/apache/spark/pull/44538#discussion_r1440601728
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala:
##########
@@ -30,7 +30,7 @@ import org.apache.spark.sql.types._
object TypeUtils extends QueryErrorsBase {
def checkForOrderingExpr(dt: DataType, caller: String): TypeCheckResult = {
Review Comment:
good catch, there are 20 usages of the function:
<img width="722" alt="Screenshot 2024-01-03 at 16 32 54"
src="https://github.com/apache/spark/assets/154237371/2096d1b9-00c9-47ed-b12d-27cc13a248f8";>
I don't have enough context, but should we maybe only change the
implementation in some of these like SortOrder and aggregate ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
