cloud-fan commented on code in PR #44538:
URL: https://github.com/apache/spark/pull/44538#discussion_r1441185359
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -2125,6 +2126,32 @@ class DataFrameAggregateSuite extends QueryTest
Seq(Row(1))
)
}
+
+ test("SPARK-46536 Support GROUP BY CalendarIntervalType") {
+ // forces the use of sort aggregate by using min/max functions
+
+ val numRows = 50
+ val numRepeat = 25
+
+ val df = (0 to numRows)
+ .map(i => Tuple1(new CalendarInterval(i, i, i)))
+ .toDF("c0")
+
+ for (_ <- 0 until numRepeat) {
+ val shuffledDf = df.orderBy(rand())
+
+ checkAnswer(
+ shuffledDf.agg(max("c0")),
Review Comment:
And we shouldn't support this. calendar interval is not orderable and can't
support min/max.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
