cloud-fan commented on code in PR #44538:
URL: https://github.com/apache/spark/pull/44538#discussion_r1441185813
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ObjectHashAggregateSuite.scala:
##########
@@ -457,4 +458,38 @@ class ObjectHashAggregateSuite
)
}
}
+
+ test("SPARK-46536 Support GROUP BY CalendarIntervalType") {
+ withSQLConf(
+ SQLConf.USE_OBJECT_HASH_AGG.key -> "true",
+ SQLConf.OBJECT_AGG_SORT_BASED_FALLBACK_THRESHOLD.key -> "1"
+ ) {
+
+ val numRows = 50
+
+ val dfSame = createAggregate(_ => Tuple1(new CalendarInterval(1, 2, 3)),
numRows)
+ assert(getPlanOutput(dfSame).contains("HashAggregate"))
Review Comment:
there are two hash aggregate operators in Spark: `HashAggregateExec` and
`ObjectHashAggregateExec`. Can we test both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
