MaxGekk commented on code in PR #44758:
URL: https://github.com/apache/spark/pull/44758#discussion_r1456307033
##########
sql/core/src/test/resources/sql-functions/sql-expression-schema.md:
##########
@@ -117,6 +117,7 @@
| org.apache.spark.sql.catalyst.expressions.DatePartExpressionBuilder |
datepart | SELECT datepart('YEAR', TIMESTAMP '2019-08-12 01:00:00.123456') |
struct<datepart(YEAR FROM TIMESTAMP '2019-08-12 01:00:00.123456'):int> |
| org.apache.spark.sql.catalyst.expressions.DateSub | date_sub | SELECT
date_sub('2016-07-30', 1) | struct<date_sub(2016-07-30, 1):date> |
| org.apache.spark.sql.catalyst.expressions.DayOfMonth | day | SELECT
day('2009-07-30') | struct<day(2009-07-30):int> |
+| org.apache.spark.sql.catalyst.expressions.DayName | dayname | SELECT
dayname(‘2008-02-20') | struct<dayname(2008-02-20):string> |
Review Comment:
Could you regenerate the file using:
```
$ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly
*ExpressionsSchemaSuite"
```
seems the test failure is related:
```
sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException:
"SELECT day[('2009-07-3]0')" did not equal "SELECT day[name('2008-02-2]0')" SQL
query did not match
at
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
