cloud-fan commented on code in PR #44758:
URL: https://github.com/apache/spark/pull/44758#discussion_r1464253727
##########
R/pkg/R/functions.R:
##########
@@ -1105,6 +1105,20 @@ setMethod("monthname",
column(jc)
})
+#' @details
+#' \code{dayname}: Extracts the three-letter abbreviated day name from a
Review Comment:
I'm fine with the function name DAYNAME, but shall we make it clearer in the
doc? `day-of-week name` instead of `day name`. This is also what snowflake
does: https://docs.snowflake.com/en/sql-reference/functions/dayname
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
