MaxGekk commented on code in PR #44758:
URL: https://github.com/apache/spark/pull/44758#discussion_r1456316417
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:
##########
@@ -909,6 +909,23 @@ case class MonthName(child: Expression) extends
GetDateField {
copy(child = newChild)
}
+@ExpressionDescription(
+ usage = "_FUNC_(date) - Returns the three-letter abbreviated day name from
the given date.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_('2008-02-20');
Review Comment:
Let's use a DATE literal explicitly, and don't assume some implicit
conversions from strings.
```suggestion
> SELECT _FUNC_(date'2008-02-20');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
