anishshri-db commented on code in PR #44961:
URL: https://github.com/apache/spark/pull/44961#discussion_r1483675627
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -204,7 +208,15 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
override def removeColFamilyIfExists(colFamilyName: String): Unit = {
throw StateStoreErrors.removingColumnFamiliesNotSupported(
"HDFSBackedStateStoreProvider")
+ }
+
+ override def valuesIterator(key: UnsafeRow, colFamilyName: String):
Iterator[UnsafeRow] = {
+ throw
StateStoreErrors.unsupportedOperationException("multipleValuesPerKey",
"HDFSStateStore")
+ }
+ override def merge(key: UnsafeRow, value: UnsafeRow,
Review Comment:
Nit: lets move all arguments to new line with required spacing ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -65,6 +65,43 @@ private[sql] class RocksDBStateStoreProvider
value
}
+ override def valuesIterator(key: UnsafeRow, colFamilyName: String):
Iterator[UnsafeRow] = {
+ verify(key != null, "Key cannot be null")
+ verify(encoder.supportsMultipleValuesPerKey, "valuesIterator requires a
encoder " +
+ "that supports multiple values for a single key.")
+ val valueIterator =
encoder.decodeValues(rocksDB.get(encoder.encodeKey(key), colFamilyName))
+
+ if (!isValidated && valueIterator.nonEmpty) {
Review Comment:
Should we just remove this ? cc - @HeartSaVioR
##########
sql/api/src/main/scala/org/apache/spark/sql/streaming/ListState.scala:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.streaming
+
+import org.apache.spark.annotation.{Evolving, Experimental}
+
+@Experimental
+@Evolving
+/**
+ * Interface used for arbitrary stateful operations with the v2 API to capture
+ * list value state.
+ */
+private[sql] trait ListState[S] extends Serializable {
+
+ /** Whether state exists or not. */
+ def exists(): Boolean
+
+ /** Get the state value if it exists */
+ def get(): Iterator[S]
+
+ /** Get the list value as an option if it exists and None otherwise */
+ def getOption(): Option[Iterator[S]]
+
+ /** Update the value of the list. */
+ def put(newState: Array[S]): Unit
+
+ /** Append an entry to the list */
+ def appendValue(newState: S): Unit
+
+ /** Append an entire list to the existing value */
+ def appendList(newState: Array[S]): Unit
+
+ /** Remove this state. */
Review Comment:
Nit: Removes this state for the given grouping key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
