sahnib commented on code in PR #44961:
URL: https://github.com/apache/spark/pull/44961#discussion_r1483695611
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -189,12 +232,15 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
numColsPrefixKey: Int,
sqlConf: Option[SQLConf] = None,
conf: Configuration = new Configuration,
- useColumnFamilies: Boolean = false): RocksDBStateStoreProvider = {
+ useColumnFamilies: Boolean = false,
+ useMultipleValuesPerKey: Boolean = false): RocksDBStateStoreProvider = {
val provider = new RocksDBStateStoreProvider()
provider.init(
storeId, keySchema, valueSchema, numColsPrefixKey = numColsPrefixKey,
useColumnFamilies,
- new StateStoreConf(sqlConf.getOrElse(SQLConf.get)), conf)
+ new StateStoreConf(sqlConf.getOrElse(SQLConf.get)), conf,
+ useMultipleValuesPerKey
Review Comment:
The indentation is actually fine here. `useMultipleValuesPerKey` is not a
parameter for `StateStoreConf`. However, I think it would be more readable if
all params are in a new line, so I have made that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
