sahnib commented on code in PR #44961:
URL: https://github.com/apache/spark/pull/44961#discussion_r1483690823
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -845,6 +859,96 @@ class RocksDBSuite extends
AlsoTestWithChangelogCheckpointingEnabled with Shared
}
}
+ testWithChangelogCheckpointingEnabled("ensure merge operation is not
supported" +
+ " with changelog checkpoint if column families is not enabled") {
+ withTempDir { dir =>
+ val remoteDir = Utils.createTempDir().toString
+ val conf = dbConf.copy(minDeltasForSnapshot = 5, compactOnCommit = false)
+ new File(remoteDir).delete() // to make sure that the directory gets
created
+ withDB(remoteDir, conf = conf, useColumnFamilies = false) { db =>
+ db.load(0)
+ db.put("a", "1")
+ intercept[UnsupportedOperationException](
+ db.merge("a", "2")
+ )
+ }
+ }
+ }
+
+ testWithChangelogCheckpointingDisabled("ensure merge operation is supported"
+
+ " without changelog checkpoint if column families is not enabled") {
Review Comment:
yeah, I did update the test to run with both changelog checkpoint enabled
and disabled. Actually, we don't need this second test now. I have removed it.
The test above covers it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
