cloud-fan commented on code in PR #45105:
URL: https://github.com/apache/spark/pull/45105#discussion_r1490415076
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -58,8 +59,8 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
* Resolve/create a primitive type.
*/
override def visitPrimitiveDataType(ctx: PrimitiveDataTypeContext): DataType
= withOrigin(ctx) {
- val typeName = ctx.`type`.start.getType
- (typeName, ctx.INTEGER_VALUE().asScala.toList) match {
+ val typeCtx = ctx.`type`
+ (typeCtx.start.getType, ctx.INTEGER_VALUE().asScala.toList) match {
Review Comment:
cc @hvanhovell @HyukjinKwon , since we put the SQL parser in the Spark
Connect Scala client component, adding new data types means a client version
upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
