dbatomic commented on code in PR #45105:
URL: https://github.com/apache/spark/pull/45105#discussion_r1495181485
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -58,8 +59,8 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
* Resolve/create a primitive type.
*/
override def visitPrimitiveDataType(ctx: PrimitiveDataTypeContext): DataType
= withOrigin(ctx) {
- val typeName = ctx.`type`.start.getType
- (typeName, ctx.INTEGER_VALUE().asScala.toList) match {
+ val typeCtx = ctx.`type`
+ (typeCtx.start.getType, ctx.INTEGER_VALUE().asScala.toList) match {
Review Comment:
adding @hvanhovell
We will have a meeting with Herman on Thursday to discuss how collations
play with Spark Connect.
I just gave it a quick spin and seems like we lack collation support in
spark connect even without this PR. e.g.
```
sql("select 'abc' collate 'UCS_BASIC_LCASE'")
```
gets us:
pyspark.errors.exceptions.connect.SparkConnectGrpcException:
(org.apache.spark.sql.connect.common.InvalidPlanInput) Does not support convert
string(UCS_BASIC_LCASE) to connect proto types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
