cloud-fan commented on code in PR #45105:
URL: https://github.com/apache/spark/pull/45105#discussion_r1495888981
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -174,4 +176,89 @@ class CollationSuite extends QueryTest with
SharedSparkSession {
Row(expected))
}
}
+
+ test("create table with collation") {
+ val tableName = "parquet_dummy_tbl"
+ val collationName = "UCS_BASIC_LCASE"
+ val collationId = CollationFactory.collationNameToId(collationName)
+
+ withTable(tableName) {
+ sql(
+ s"""
+ |CREATE TABLE $tableName (c1 STRING COLLATE '$collationName')
+ |USING PARQUET
+ |""".stripMargin)
+
+ sql(s"INSERT INTO $tableName VALUES ('aaa')")
+ sql(s"INSERT INTO $tableName VALUES ('AAA')")
+
+ checkAnswer(sql(s"SELECT DISTINCT COLLATION(c1) FROM $tableName"),
Seq(Row(collationName)))
+ assert(sql(s"select c1 FROM $tableName").schema.head.dataType ==
StringType(collationId))
+ val dd = sql(s"SELECT c1 FROM $tableName").toDF("c2")
+ dd.write.mode(SaveMode.Overwrite).parquet("/tmp/stefan_tbl")
Review Comment:
please use `withTempPath` to generate the temp path and write.
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -174,4 +176,89 @@ class CollationSuite extends QueryTest with
SharedSparkSession {
Row(expected))
}
}
+
+ test("create table with collation") {
+ val tableName = "parquet_dummy_tbl"
+ val collationName = "UCS_BASIC_LCASE"
+ val collationId = CollationFactory.collationNameToId(collationName)
+
+ withTable(tableName) {
+ sql(
+ s"""
+ |CREATE TABLE $tableName (c1 STRING COLLATE '$collationName')
+ |USING PARQUET
+ |""".stripMargin)
+
+ sql(s"INSERT INTO $tableName VALUES ('aaa')")
+ sql(s"INSERT INTO $tableName VALUES ('AAA')")
+
+ checkAnswer(sql(s"SELECT DISTINCT COLLATION(c1) FROM $tableName"),
Seq(Row(collationName)))
+ assert(sql(s"select c1 FROM $tableName").schema.head.dataType ==
StringType(collationId))
+ val dd = sql(s"SELECT c1 FROM $tableName").toDF("c2")
+ dd.write.mode(SaveMode.Overwrite).parquet("/tmp/stefan_tbl")
Review Comment:
can we also test read it back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
