dbatomic commented on code in PR #45104: URL: https://github.com/apache/spark/pull/45104#discussion_r1495055910
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala: ########## @@ -574,6 +573,14 @@ object PartitioningUtils extends SQLConfHelper { } } + /** + * Checks whether a given data type can be used as a partition column. + */ + def canPartitionOn(dateType: DataType): Boolean = dateType match { + case st: StringType => st.isDefaultCollation Review Comment: Hey, I know that Spark codebase is not big on comments, but maybe we should add a comment why partitioning is disabled + jira ticket to enable the partitioning :) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org