stefankandic commented on code in PR #45104:
URL: https://github.com/apache/spark/pull/45104#discussion_r1503072440
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -174,4 +174,36 @@ class CollationSuite extends QueryTest with
SharedSparkSession {
Row(expected))
}
}
+
+
+ test("disable partition on collated string column") {
+ def createTable(partitionColumns: String*): Unit = {
+ val tableName = "test_partition_tbl"
+ withTable(tableName) {
+ sql(
+ s"""
+ |CREATE TABLE $tableName
Review Comment:
it seems that we don't even check if partitioning is allowed or not for v2
table creation
([code](https://github.com/apache/spark/blob/a939a7d0fd9c6b23c879cbee05275c6fbc939e38/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala#L251)),
is this a bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
