cloud-fan commented on code in PR #45104:
URL: https://github.com/apache/spark/pull/45104#discussion_r1495894928
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala:
##########
@@ -574,6 +573,16 @@ object PartitioningUtils extends SQLConfHelper {
}
}
+ /**
+ * Checks whether a given data type can be used as a partition column.
+ */
+ def canPartitionOn(dateType: DataType): Boolean = dateType match {
+ // non default collated strings should not be used as partition columns
+ // as it could lead to incorrect results
Review Comment:
let's be more specific. "... as we cannot implement string collation
semantic with directory names."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
