dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502774167
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -559,6 +557,19 @@ case class BinaryPredicate(override val prettyName:
String, left: Expression, ri
}
}
+trait CollationCheck {
+ self: BinaryExpression =>
Review Comment:
I think that you should implement this against `StringPredicate` instead of
`BinaryExpression`. If it is just `BinaryExpression` you don't have any
guarantee that `asInstanceOf[StringType]` will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
