dbatomic commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502783545
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -622,10 +646,24 @@ object StartsWithExpressionBuilder extends
StringBinaryPredicateExpressionBuilde
}
}
-case class StartsWith(left: Expression, right: Expression) extends
StringPredicate {
- override def compare(l: UTF8String, r: UTF8String): Boolean = l.startsWith(r)
+case class StartsWith(left: Expression, right: Expression) extends
StringPredicate
+ with CollationCheck {
+ override def compare(l: UTF8String, r: UTF8String): Boolean = {
+ val collationId = checkCollationIds()
+ if (CollationFactory.fetchCollation(collationId).isBinaryCollation) {
+ l.startsWith(r)
Review Comment:
Let's think about naming here. I don't like the idea that startsWith without
collation implies binary check. Can we call these methods
`startsWithBinary`/`containsBinary` etc.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
