uros-db commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1502791434
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -341,6 +340,15 @@ public boolean contains(final UTF8String substring) {
return false;
}
+ public boolean contains(final UTF8String substring, int collationId) {
+ if (collationId == CollationFactory.LOWERCASE_COLLATION_ID) {
Review Comment:
That was the case previously. However, as of the last commit, that part is
handled in stringExpressions.scala in order not to regress the performance for
the original (current) implementation of contains/startsWith/endsWith that uses
the default collation. As we discussed somewhere above, it's imperative to take
care of that case early over there, while all non-binary collations pass
through to UTF8String.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
