cloud-fan commented on code in PR #45321:
URL: https://github.com/apache/spark/pull/45321#discussion_r1506918858
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala:
##########
@@ -243,13 +243,22 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] {
self: LogicalPlan =>
* subtree. Do not pass it if the rule is not purely
functional and reads a
* varying initial state for different invocations.
*/
- def resolveExpressionsWithPruning(cond: TreePatternBits => Boolean,
Review Comment:
If you look at other methods in this file, they usually have 3 variants:
1. no up and down in the name, which calls the down version
2. the down version
3. the up version
We should follow it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
