amaliujia commented on code in PR #45321:
URL: https://github.com/apache/spark/pull/45321#discussion_r1507931889
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala:
##########
@@ -222,15 +222,23 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] {
self: LogicalPlan =>
}
/**
- * Recursively transforms the expressions of a tree, skipping nodes that
have already
+ * Recursively top-down transforms the expressions of a tree, skipping nodes
that have already
Review Comment:
Removed for the default version.
This was a problem to me that I didn't know the implementation details by
reading the comment. I only realized it when writing code which took me some
time. But probably it was only personal experience.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala:
##########
@@ -222,15 +222,23 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] {
self: LogicalPlan =>
}
/**
- * Recursively transforms the expressions of a tree, skipping nodes that
have already
+ * Recursively top-down transforms the expressions of a tree, skipping nodes
that have already
Review Comment:
Removed for the default versions.
This was a problem to me that I didn't know the implementation details by
reading the comment. I only realized it when writing code which took me some
time. But probably it was only personal experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
