cloud-fan commented on code in PR #45321:
URL: https://github.com/apache/spark/pull/45321#discussion_r1512050470
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala:
##########
@@ -229,6 +229,14 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] {
self: LogicalPlan =>
resolveExpressionsWithPruning(AlwaysProcess.fn, UnknownRuleId)(r)
}
+ /**
+ * Recursively top-down transforms the expressions of a tree, skipping nodes
that have already
+ * been analyzed.
+ */
+ def resolveExpressionsDown(r: PartialFunction[Expression, Expression]):
LogicalPlan = {
Review Comment:
super nit: shall we put this method right before
`resolveExpressionsDownWithPruning`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
