ahshahid commented on code in PR #45446:
URL: https://github.com/apache/spark/pull/45446#discussion_r1521997698
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -477,6 +482,57 @@ trait ColumnResolutionHelper extends Logging with
DataTypeErrorsBase {
assert(q.children.length == 1)
q.children.head.output
},
+
+ resolveOnDatasetId = (datasetid: Long, name: String) => {
Review Comment:
> > can you check out function `tryResolveDataFrameColumns` in this file and
see if it matches your expectations?
>
> I will check it out but isn't plan Id tag set only when using Client ?
The tryResolveDataFrameColumns will not help for 2 reasons..
1) Plan ID is added only when code path uses SQLConnect
2) There are cases, where AttributeReference is already added as resolved.
That resolution may have been incorrect as it is not based on the deduplication
plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
