ahshahid commented on code in PR #45446:
URL: https://github.com/apache/spark/pull/45446#discussion_r1527072175
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -477,6 +482,57 @@ trait ColumnResolutionHelper extends Logging with
DataTypeErrorsBase {
assert(q.children.length == 1)
q.children.head.output
},
+
+ resolveOnDatasetId = (datasetid: Long, name: String) => {
Review Comment:
@peter-toth @cloud-fan,
Attached is the patch which describes the attempt to use planID resolution
logic. But that does not work because the planID resolution logic goes till the
full depth and even attempt to early end the recursion does not work, as the
comparison of the return values of the recursion results, does not contain
sufficient data. And further attempt to somehow reuse that code, is proving
too cumbersome for me.
[patch.txt](https://github.com/apache/spark/files/14622366/patch.txt)
Though I have removed the previously added new class
UnresolvedAttributeWithTag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
