ahshahid commented on code in PR #45446:
URL: https://github.com/apache/spark/pull/45446#discussion_r1523844585
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -477,6 +482,57 @@ trait ColumnResolutionHelper extends Logging with
DataTypeErrorsBase {
assert(q.children.length == 1)
q.children.head.output
},
+
+ resolveOnDatasetId = (datasetid: Long, name: String) => {
Review Comment:
@cloud-fan @peter-toth I applied the patch #43115 and verified that in
df.select , the projection is added with Alias having UnresolvedAttribute.
There are many test failures in DataFrameSelfJoinSuite with that change. So
atleast with the current code base of spark with patch #43115 is not sufficient
to fix new bugs which are encountered nor the existing tests pass. If planId
has to be used to fix the issue so that the current code of
tryResolveDataFrameColumns can fix the problem, then atleast it will need
modification & debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
