dbatomic commented on code in PR #45422:
URL: https://github.com/apache/spark/pull/45422#discussion_r1525992996
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -65,9 +64,41 @@ class StringType private(val collationId: Int) extends
AtomicType with Serializa
}
/**
+ * Use StringType for expressions supporting only binary collation.
+ *
* @since 1.3.0
*/
@Stable
case object StringType extends StringType(0) {
def apply(collationId: Int): StringType = new StringType(collationId)
}
+
+/**
+ * Use StringTypeBinary for expressions supporting only binary collation.
+ */
+case object StringTypeBinary extends AbstractDataType {
Review Comment:
Does it make sense to move this into `CollationTypeConstraints.scala`?
I would suggest to at least be explicit and say that these are not actual
types that can be constructed/used externally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
