cloud-fan commented on code in PR #45422: URL: https://github.com/apache/spark/pull/45422#discussion_r1526067004
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ########## @@ -994,8 +994,10 @@ object TypeCoercion extends TypeCoercionBase { case (StringType, datetime: DatetimeType) => datetime case (StringType, AnyTimestampType) => AnyTimestampType.defaultConcreteType case (StringType, BinaryType) => BinaryType + case (st: StringType, StringType) => st // Cast any atomic type to string. case (any: AtomicType, StringType) if any != StringType => StringType Review Comment: is it possible that a function uses `StringType(id)` as the expected input type? i.e. only allow string with certain collation id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org