uros-db commented on code in PR #45422: URL: https://github.com/apache/spark/pull/45422#discussion_r1526092915
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala: ########## @@ -205,6 +205,10 @@ object AnsiTypeCoercion extends TypeCoercionBase { case (StringType, AnyTimestampType) => Some(AnyTimestampType.defaultConcreteType) + // If the StringType has any collation other than UTF8_BINARY, it shouldn't be implicitly + // cast to StringType with collation 0. Review Comment: perhaps the explanation is unclear, see how this sounds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org