tgravescs commented on PR #45587: URL: https://github.com/apache/spark/pull/45587#issuecomment-2007935739
well it definitely changes the synchronization, everywhere else that is referenced is in synchronized block. Now since its only testing I'm not sure if you will see any issues there. At the same time this feels like one of those prs that doesn't need to be done and is just introducing risk. It was also abstracting things so you weren't going straight into the listener. I think listener should really be private here but looking at history was opened up for a test that doesn't exist. Personally I would prefer to see this reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
