LuciferYang commented on PR #45587: URL: https://github.com/apache/spark/pull/45587#issuecomment-2008697337
1. I am fine to revert this commit, but while revert, I think some comments should be added to the `totalRunningTasksPerResourceProfile ` function to clarify that this function needs to be retained for testing. 2. Another thing I want to clarify is, should we restrict the access level of listener to private? Would this action pose any risks? @dongjoon-hyun @tgravescs @mridulm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
