mridulm commented on PR #45587: URL: https://github.com/apache/spark/pull/45587#issuecomment-2008669180
I was looking at it from point of view of, is the change safe - is the behavior the same before and after ? From that point of view, at face value of the PR, it appears that it need not be the same after the PR - the access was protected earlier by a synchronized lock, and could have ensured visibility of updates. I have ofcourse not done an analysis of whether this safety is required, are there other mitigating reasons why it is still safe (perhaps an outer lock, etc) ... and so tagged Tom. Note that there is also diminishing reasons given this is for tests, and is a private method :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
