cloud-fan commented on code in PR #45592:
URL: https://github.com/apache/spark/pull/45592#discussion_r1537889609
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4999,7 +4999,12 @@ class SQLConf extends Serializable with Logging with
SqlApiConf {
def collationEnabled: Boolean = getConf(COLLATION_ENABLED)
- def defaultCollation: String = getConf(DEFAULT_COLLATION)
+ override def defaultStringType: StringType = {
+ if (getConf(DEFAULT_COLLATION) == "UTF8_BINARY") {
+ StringType
+ }
+ else
StringType(CollationFactory.collationNameToId(getConf(DEFAULT_COLLATION)))
+ }
Review Comment:
```suggestion
} else {
StringType(CollationFactory.collationNameToId(getConf(DEFAULT_COLLATION)))
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]